Shadow indexing metrics #3881
Merged
Shadow indexing metrics #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnwat
previously approved these changes
Feb 23, 2022
emaxerrno
reviewed
Feb 23, 2022
Lazin
previously approved these changes
Mar 3, 2022
Removed the metric as it belongs to the ntp level.
Previously, upload lag was calculated in archival_policy, which could be misleading as start_offset passed to it can be greater than the offset that was uploaded (e.g. in case when several upload candidates are created in one pass).
Previously, offset gaps metric was incremented in the archival_policy methods, which could be incorrect because archival_policy can be called many times without actually uploading any segments. Also the code missed the case when there is a gap between local segments. We increment this metric after actually uploading a segment, which is more robust.
ztlpn
force-pushed
the
shadow-indexing-metrics
branch
2 times, most recently
from
088a01e
to
fe8e19a
Compare
|
Rebased to the tip of dev and replaced current counts to 32-bit integer in the |
Lazin
approved these changes
Mar 3, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Improve shadow indexing metrics:
Fixes: #2818
Release notes
Improvements