Reset leaders table #4237
Merged
Reset leaders table #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
reviewed
Apr 8, 2022
mmaslankaprv
reviewed
Apr 8, 2022
VadimPlh
force-pushed
the
reset-leaders-table
branch
from
ced459b
to
c898bd9
Compare
VadimPlh
force-pushed
the
reset-leaders-table
branch
from
c898bd9
to
124500e
Compare
dotnwat
reviewed
Apr 8, 2022
VadimPlh
force-pushed
the
reset-leaders-table
branch
2 times, most recently
from
78d6d09
to
5a4c565
Compare
This request is used to refresh leaders info on node User can invoke it by using admin api On some cases leaders_table can not be updated long time So client request can be failed in this cases. New request allows us force leaders table by hand, after it shard should be refresh all info about leaders. After reset leaders info, metadata responce will not contain leaders for all partition during short period of time ~150ms. heartbits delay or leader notification delay.
VadimPlh
force-pushed
the
reset-leaders-table
branch
from
5a4c565
to
fd526e9
Compare
jcsp
reviewed
Apr 11, 2022
VadimPlh
force-pushed
the
reset-leaders-table
branch
from
fd526e9
to
f27ab17
Compare
jcsp
reviewed
Apr 11, 2022
jcsp
reviewed
Apr 11, 2022
|
👍 test looks pretty reasonable to me now. Not sure if Noah had some other thoughts about alternatives to EndToEndTest, so will pause for input in his daytime before proceeding |
VadimPlh
force-pushed
the
reset-leaders-table
branch
from
f27ab17
to
9f5b987
Compare
VadimPlh
force-pushed
the
reset-leaders-table
branch
from
9f5b987
to
fcd5acd
Compare
This was
linked to
issues
Apr 16, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
This pr implements new admin_api request to reset leaders_table on node.
On some cases leaders_table can not be updated long time. So client request can be failed in this cases.
New request allows us force leaders table by hand, after it shard should be refresh all info about leaders.
Release notes
/v1/debug/reset_leadersrequest to reset leaders info on node