redpanda: remove _redpanda_enabled=false mode #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
force-pushed
the
no-standalone-schema-reg
branch
2 times, most recently
from
110044c
to
6beebd9
Compare
|
CI failure was known issue #4887 |
dotnwat
previously approved these changes
Jun 8, 2022
src/v/redpanda/application.cc
Outdated
Comment on lines
361
to
447
| // This includes loading from local bootstrap file or legacy | ||
| // config file on first-start or upgrade cases. | ||
| _config_preload = cluster::config_manager::preload(config).get0(); | ||
| auto node_config_errors = config::node().load(config); | ||
| for (const auto& i : node_config_errors) { | ||
| vlog( |
There was a problem hiding this comment.
Whitespace update in subsequent commit, because all the indentation
jumps around & otherwise it's not obvious what I'm doing here.
wow you're not kidding
Redpanda is always enabled.
Whitespace update in subsequent commit, because all the indentation jumps around & otherwise it's not obvious what I'm doing here.
jcsp
force-pushed
the
no-standalone-schema-reg
branch
from
6beebd9
to
6ef1f84
Compare
dotnwat
approved these changes
Aug 23, 2022
| @@ -438,8 +438,6 @@ void application::hydrate_config(const po::variables_map& cfg) { | |||
| } | |||
There was a problem hiding this comment.
Whitespace update in subsequent commit, because all the indentation
jumps around & otherwise it's not obvious what I'm doing here.
🙏
|
from what i can tell this PR |
Yep. As far as I can tell, there aren't even any doc changes, because the old standalone modes were undocumented. |
mmedenjak
added
kind/tech-debt
area/schema-registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
This was the code path for running schema registry
outside of a redpanda cluster. Once we always
run schema registry inside a redpanda cluster,
this is no longer necessary.
Fixes https://github.com/redpanda-data/core-internal/issues/35
Release notes
Improvements