k8s: fix lint warnings and disabling gomnd #4396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Bumping
golangci-lint
version from '1.40.1' -> '1.45.2' brings a few linter warnings, this PR addresses those and disablesgomnd
from the linter configuration.The reason to disable gomnd is that it introduces warnings for magic numbers that doesn't make sense in go built in functions, e.g tommy-muehle/go-mnd#27
Release notes