Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stale metadata check inside shard_for #4413

Closed
wants to merge 1 commit into from
+27 −17
Closed

Move stale metadata check inside shard_for #4413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 27 additions & 17 deletions src/v/kafka/server/handlers/fetch.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,26 +439,36 @@ class simple_fetch_planner final : public fetch_planner::impl {
auto ntp = model::ntp(
model::kafka_namespace, fp.topic, fp.partition);

// there is given partition in topic metadata, return
// unknown_topic_or_partition error
if (unlikely(!octx.rctx.metadata_cache().contains(ntp))) {
resp_it->set(make_partition_response_error(
fp.partition, error_code::unknown_topic_or_partition));
++resp_it;
return;
}

auto shard = octx.rctx.shards().shard_for(ntp);
if (!shard) {
/**
* no shard is found on current node, but topic exists in
* cluster metadata, this mean that the partition was moved
* but consumer has not updated its metadata yet. we return
* not_leader_for_partition error to force metadata update.
if (unlikely(!shard)) {
/*
* If the shard associated with the ntp isn't found on the
* current node then either (1) the ntp doesn't exist at all
* (e.g., it has been deleted) or (2) it has been moved and
* the client's metadata is stale.
*/
resp_it->set(make_partition_response_error(
fp.partition, error_code::not_leader_for_partition));

error_code ec;
if (!octx.rctx.metadata_cache().contains(ntp)) {
/*
* Case (1) the given topic/partition does not exist in
* topic metadata, return unknown_topic_or_partition error
*/
ec = error_code::unknown_topic_or_partition;
} else {
/*
* Case (2): no shard is found on current node, but topic
* exists in cluster metadata, this mean that the
* partition was moved but consumer has not updated its
* metadata yet. we return not_leader_for_partition error
* to force metadata update.
*/
ec = error_code::not_leader_for_partition;
}

resp_it->set(make_partition_response_error(fp.partition, ec));
++resp_it;

return;
}

Expand Down