Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ducktape: GroupMetricsTest check if leader exists #4442

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

ZeDRoman
Copy link
Contributor

@ZeDRoman ZeDRoman commented Apr 26, 2022

Cover letter

In failure attached by Lena here: #3394 (comment)
I found problem with leader check.

In group description Redpanda returns {'ns': 'kafka_internal', 'topic': 'group', 'partition_id': 0, 'status': 'done', 'leader_id': -1, 'raft_group_id': 8, 'replicas': [{'node_id': 3, 'core': 0}, {'node_id': 2, 'core': 0}, {'node_id': 1, 'core': 0}]}
Where leader_id is -1. self.redpanda.get_node(leader) == new_leader accepts this.

This happens because self.redpanda.get_node(idx) returns this self.nodes[idx - 1]

Fixes #3394

@ZeDRoman ZeDRoman added the ci-repeat-5 repeat tests 5x concurrently to check for flakey tests; self-cancelling label Apr 27, 2022
@vbotbuildovich vbotbuildovich removed the ci-repeat-5 repeat tests 5x concurrently to check for flakey tests; self-cancelling label Apr 27, 2022
@ZeDRoman ZeDRoman marked this pull request as ready for review April 27, 2022 15:02
Copy link
Contributor

@NyaliaLui NyaliaLui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent find.

@ZeDRoman ZeDRoman merged commit dfd73b9 into redpanda-data:dev Apr 27, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failure of rptest.tests.group_membership_test.GroupMetricsTest.test_leadership_transfer test
3 participants