[v22.1.x] backport #4390 #4480
Merged
[v22.1.x] backport #4390 #4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An older broker will not include this field in the returned json and the field pointer will be nil. Signed-off-by: Noah Watkins <noah@redpanda.com> (cherry picked from commit c185eae)
Signed-off-by: Noah Watkins <noah@redpanda.com> (cherry picked from commit 029b0cc)
Signed-off-by: Noah Watkins <noah@redpanda.com> (cherry picked from commit c6117c9)
The --wait option can be used to block until the cluster reports that draining is complete for a broker that has been put into maintenance mode. Signed-off-by: Noah Watkins <noah@redpanda.com> (cherry picked from commit b194a21)
Signed-off-by: Noah Watkins <noah@redpanda.com> (cherry picked from commit 2348187)
This uses rpk cluster maintenance status to augment existing checks that depend on the raw admin api for querying status. The version of the tests require that both interfaces agree on the status. Signed-off-by: Noah Watkins <noah@redpanda.com> (cherry picked from commit 3bb7f06)
Signed-off-by: Noah Watkins <noah@redpanda.com> (cherry picked from commit a7909d1)
Signed-off-by: Noah Watkins <noah@redpanda.com> (cherry picked from commit bc33517)
Prior to this change ducktape wait_until was used to create a barrier to wait on maintenance mode and a node being drained. having this built-in to rpk is useful for cases like manually running an upgrade where waiting on draining to complete is interactive, or added into a script. Signed-off-by: Noah Watkins <noah@redpanda.com> (cherry picked from commit 9df7079)
struct field tag `json:"version` not compatible with reflect.StructTag.Get: bad syntax for struct tag value Signed-off-by: Noah Watkins <noah@redpanda.com> (cherry picked from commit bc4b155)
NyaliaLui
approved these changes
Apr 28, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR: #4390
Fixes: #4435