[v22.1.x] Fix raft linearizable barrier #4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Track last sequence number of last received successful append entries response. Last successful append entries response will allow leader to determine if majority of followers is up to date and receive heartbeats. Signed-off-by: Michal Maslanka <michal@vectorized.io> (cherry picked from commit 5c4d80e)
Signed-off-by: Michal Maslanka <michal@vectorized.io> (cherry picked from commit 34a6744)
Fixed linearizable barrier to provide a true linearizability barrier. Previously we skipped leader flush and checks if returned responses were successful. This might lead to situation in which after returning from a barrier `_committed_offset` might not have been updated. This wasn't critical issue as offset returned from barrier was still valid i.e. reads would not cause inconsistency however read wasn't linearizble as it might not seen all the writes. Signed-off-by: Michal Maslanka <michal@vectorized.io> (cherry picked from commit 20330df)
Signed-off-by: Michal Maslanka <michal@vectorized.io> (cherry picked from commit 82f1567)
In redpanda-data#3807 a fix was made to deal with timeouts on ARM. We are seeing this again so bumping the timeout again. Related: redpanda-data#3807 Related: redpanda-data#3797 Signed-off-by: Noah Watkins <noah@redpanda.com> (cherry picked from commit 827b744)
vbotbuildovich
requested review from
jcsp,
ztlpn,
NyaliaLui,
VadimPlh and
ZeDRoman
rystsov
approved these changes
May 3, 2022
|
@mmaslankaprv different CI failures on different runs for debug. |
Signed-off-by: Michal Maslanka <michal@vectorized.io> (cherry picked from commit c283d63)
We do not want to change the semantics of `consensus::linearizble_barrier` therefore we should not flush leader log as a part of setting a barrier. This makes the semantics consistent Signed-off-by: Michal Maslanka <michal@vectorized.io> (cherry picked from commit 9c5b1af)
|
Failure appears to be a case of ARM being close to elect a leader #4566 and rpk giving up after a few retries in response to 503. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from pull request: #4507
Also contained in this PR is backport for #4555