-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable coproc on ci #4557
Changes from all commits
aa7cdd8
e70b777
964bb41
811ce07
170168d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,39 +47,3 @@ def rpk_partition_sort(p): | |
if output != test_cfg: | ||
raise Exception("Bad config, expected: %s observed: %s" % | ||
(test_cfg, output)) | ||
|
||
|
||
class WasmDeleteTopicsTest(WasmIdentityTest): | ||
def __init__(self, test_context, num_records=10, record_size=1024): | ||
super(WasmDeleteTopicsTest, self).__init__(test_context, | ||
extra_rp_conf=None, | ||
num_records=num_records, | ||
record_size=record_size) | ||
|
||
def wasm_test_plan(self): | ||
return [ | ||
WasmScript(inputs=self.wasm_test_input(), | ||
outputs=["output_1", "output_2", "output_3"], | ||
script=WasmTemplateRepository.IDENTITY_TRANSFORM) | ||
] | ||
|
||
@ok_to_fail # https://github.com/redpanda-data/redpanda/issues/3745 | ||
@cluster(num_nodes=4) | ||
def verify_materialized_topics_test(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm concerned about the gap left in test coverage after this commit is merged. Should we document somewhere that we need a WasmDeleteTopics test in the future? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I left the explanation in the commit message, is there somewhere else better we could put this? Maybe a link in the source? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fair point. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think when we re-pick up the WASM workstream, we will want to look at what all tests are required. That said, I wonder if we leave such tests...commented out rather than delete? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I specifically deleted it as stated in the commit because it was working as expected. Deleting materialized topics while coprocessors are still processing inputs may re-create said topics |
||
super().verify_materialized_topics_test() | ||
|
||
for topic in self.wasm_test_output(): | ||
self._rpk_tool.delete_topic(topic) | ||
self._rpk_tool.delete_topic(self.topic) | ||
|
||
topics = self._rpk_tool.list_topics() | ||
|
||
for topic in self.wasm_test_output(): | ||
if topic in topics: | ||
raise Exception( | ||
'Failed to delete materialized topic %s - topics: %s' % | ||
(topic, topics)) | ||
|
||
if self.topic in topics: | ||
raise Exception('Failed to delete source topic: %s - topics: %s' % | ||
(self.topic, topics)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why aren't we using @ignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to clutter ci output with more coproc stuff