Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable coproc on ci #4557

Merged
merged 5 commits into from
May 6, 2022
Merged

Temporarily disable coproc on ci #4557

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa7cdd8
rptest/services: Wait for wasm_engine to shutdown
May 4, 2022
e70b777
rptest/services: Clean wasm engine if coproc
May 4, 2022
964bb41
coproc: Remove some topic delete tests
May 4, 2022
811ce07
coproc/tests: Disable tests on CI
May 4, 2022
170168d
rptest: Exclude wasm from ducktape test suite
May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/v/coproc/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,3 @@ rp_test(
LIBRARIES v::seastar_testing_main ${fixture_deps}
LABELS coproc
)

rp_test(
UNIT_TEST
BINARY_NAME coproc_unstable_fixture
SOURCES ${fixture_srcs} pacemaker_unstable_tests.cc
DEFINITIONS BOOST_TEST_DYN_LINK
LIBRARIES v::seastar_testing_main ${fixture_deps}
LABELS coproc disable_on_ci
)
148 changes: 0 additions & 148 deletions src/v/coproc/tests/pacemaker_unstable_tests.cc
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions tests/rptest/tests/wasm_topics_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,39 +47,3 @@ def rpk_partition_sort(p):
if output != test_cfg:
raise Exception("Bad config, expected: %s observed: %s" %
(test_cfg, output))


class WasmDeleteTopicsTest(WasmIdentityTest):
def __init__(self, test_context, num_records=10, record_size=1024):
super(WasmDeleteTopicsTest, self).__init__(test_context,
extra_rp_conf=None,
num_records=num_records,
record_size=record_size)

def wasm_test_plan(self):
return [
WasmScript(inputs=self.wasm_test_input(),
outputs=["output_1", "output_2", "output_3"],
script=WasmTemplateRepository.IDENTITY_TRANSFORM)
]

@ok_to_fail # https://github.com/redpanda-data/redpanda/issues/3745
@cluster(num_nodes=4)
def verify_materialized_topics_test(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about the gap left in test coverage after this commit is merged. Should we document somewhere that we need a WasmDeleteTopics test in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the explanation in the commit message, is there somewhere else better we could put this? Maybe a link in the source?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when we re-pick up the WASM workstream, we will want to look at what all tests are required. That said, I wonder if we leave such tests...commented out rather than delete?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specifically deleted it as stated in the commit because it was working as expected. Deleting materialized topics while coprocessors are still processing inputs may re-create said topics

super().verify_materialized_topics_test()

for topic in self.wasm_test_output():
self._rpk_tool.delete_topic(topic)
self._rpk_tool.delete_topic(self.topic)

topics = self._rpk_tool.list_topics()

for topic in self.wasm_test_output():
if topic in topics:
raise Exception(
'Failed to delete materialized topic %s - topics: %s' %
(topic, topics))

if self.topic in topics:
raise Exception('Failed to delete source topic: %s - topics: %s' %
(self.topic, topics))