rpk: generate pool of available ports for container start command #4565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twmb
reviewed
May 4, 2022
twmb
reviewed
May 4, 2022
r-vasquez
force-pushed
the
fix-test-container
branch
from
ec75490
to
c4580be
Compare
twmb
approved these changes
May 4, 2022
jcsp
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
This PR changes the way rpk handles the port assignment for each redpanda node when using
rpk container startto fix a race between redpanda start and ourvnet.GetFreePot()Now it will preallocate all available ports before starting the nodes.
Fixes #2418
Release notes