test: create directory for certs before copying #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the directory in which certs are copied to does not exist then an error will be thrown. This PR ensure the target directory exists before copying the cert files. Fixes: redpanda-data#4552 Signed-off-by: Noah Watkins <noah@redpanda.com>
|
/backport v22.1.x |
|
The pull request is not merged yet. Cancelling backport... |
piyushredpanda
approved these changes
May 5, 2022
|
Was about to ask if we should check if dir exists before creating to avoid an error but it looks like this function uses |
abhijat
approved these changes
May 5, 2022
|
/backport v22.1.x |
This was referenced May 5, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
If the directory in which certs are copied to does not exist then an
error will be thrown. This PR ensure the target directory exists before
copying the cert files.
Fixes: #4552
Testing. I suppose other issues could cause this, but I simulated this scenario by manually manipulating paths and it produced the same error. Further, bootstrap config writing also initializes the target directory suggesting this may have been encountered before.
Release notes