Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce raft_availability ducktape execution time #4598

Merged
merged 2 commits into from
May 18, 2022

Conversation

rystsov
Copy link
Contributor

@rystsov rystsov commented May 6, 2022

Cover letter

The change reduces test_follower_isolation execution time from 6 minutes to 30 seconds.

Release notes

  • none

tests/rptest/tests/raft_availability_test.py Outdated Show resolved Hide resolved
tests/rptest/clients/ping_pong.py Outdated Show resolved Hide resolved
tests/rptest/clients/ping_pong.py Outdated Show resolved Hide resolved
tests/rptest/tests/raft_availability_test.py Outdated Show resolved Hide resolved
@rystsov
Copy link
Contributor Author

rystsov commented May 6, 2022

Before:

----------------------------------------------------------------------------------------------------
test_id:    rptest.tests.raft_availability_test.RaftAvailabilityTest.test_follower_isolation
status:     PASS
run time:   7 minutes 24.895 seconds
----------------------------------------------------------------------------------------------------

After:

----------------------------------------------------------------------------------------------------
test_id:    rptest.tests.raft_availability_test.RaftAvailabilityTest.test_follower_isolation
status:     PASS
run time:   37.377 seconds
----------------------------------------------------------------------------------------------------

@rystsov rystsov added the ci-repeat-10 repeat tests 10x concurrently to check for flakey tests; self-cancelling label May 6, 2022
@vbotbuildovich vbotbuildovich removed the ci-repeat-10 repeat tests 10x concurrently to check for flakey tests; self-cancelling label May 6, 2022
@rystsov rystsov marked this pull request as draft May 6, 2022 19:06
@rystsov rystsov added the ci-repeat-10 repeat tests 10x concurrently to check for flakey tests; self-cancelling label May 6, 2022
@vbotbuildovich vbotbuildovich removed the ci-repeat-10 repeat tests 10x concurrently to check for flakey tests; self-cancelling label May 6, 2022
@rystsov rystsov added the ci-repeat-10 repeat tests 10x concurrently to check for flakey tests; self-cancelling label May 6, 2022
@vbotbuildovich vbotbuildovich removed the ci-repeat-10 repeat tests 10x concurrently to check for flakey tests; self-cancelling label May 6, 2022
@rystsov rystsov added the ci-repeat-10 repeat tests 10x concurrently to check for flakey tests; self-cancelling label May 7, 2022
@vbotbuildovich vbotbuildovich removed the ci-repeat-10 repeat tests 10x concurrently to check for flakey tests; self-cancelling label May 7, 2022
@rystsov rystsov marked this pull request as ready for review May 9, 2022 14:36
@rystsov rystsov requested a review from jcsp May 9, 2022 14:36
PingPong client abstracts the core Redpanda functionality and checks its
basic invariant: the client writes a random key/value pair, gets an offset
and then reads the log until it sees the written record or times out when
it isn't found
Replaces ad hoc ping-pong check with ping-pong client. The client
maintains a connection so when we invoke ping-pong 128 times it
initializes a producer (init_producer_id) only once.

The change reduces test_follower_isolation execution time from 6
minutes to 30 seconds.
Copy link
Contributor

@jcsp jcsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rystsov rystsov merged commit 0df1ca7 into redpanda-data:dev May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants