Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s/configurator: remove unneeded log stmnt #4652

Merged
merged 1 commit into from
May 10, 2022
Merged

k8s/configurator: remove unneeded log stmnt #4652

merged 1 commit into from
May 10, 2022

Conversation

0x5d
Copy link
Contributor

@0x5d 0x5d commented May 10, 2022 •
edited by andrewhsu
Loading

Cover letter

Fixes #4650

Removes an unnecessary log statement when the k8s configurator loads the config.

@0x5d 0x5d requested a review from a team as a code owner May 10, 2022 17:05
@0x5d 0x5d self-assigned this May 10, 2022
@CLAassistant
Copy link

CLAassistant commented May 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

RafalKorepta
RafalKorepta approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@RafalKorepta RafalKorepta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add release notes section for Devprod convenience ;)

@andrewhsu
Copy link
Member

@0x5d also needs you to click on the yellow CLA not signed yet button to go through the CLA signing process #4652 (comment)

i know you've signed before on previous PRs, but i think you need to go through it again now that we've switch to @redpanda.com email addresses.

@0x5d
Copy link
Contributor Author

0x5d commented May 10, 2022

@0x5d also needs you to click on the yellow CLA not signed yet button to go through the CLA signing process #4652 (comment)

i know you've signed before on previous PRs, but i think you need to go through it again now that we've switch to @redpanda.com email addresses.

Thanks for the heads up. I accepted the CLA.

andrewhsu
andrewhsu approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CLA signed and PR checks are all green

@andrewhsu andrewhsu merged commit 8e213ef into redpanda-data:dev May 10, 2022
@0x5d 0x5d deleted the configurator-rm-log branch May 10, 2022 21:04
@andrewhsu andrewhsu mentioned this pull request May 10, 2022
Closed
@RafalKorepta
Copy link
Contributor

/backport v21.11.x

@vbotbuildovich
Copy link
Collaborator

Failed to run cherry-pick command. see workflow
I executed the below command:

git cherry-pick -x eaab4ea1fff73191848d245c45fda56349cae5ac

@RafalKorepta
Copy link
Contributor

/backport v22.1.x

@vbotbuildovich vbotbuildovich mentioned this pull request May 10, 2022
Merged
@RafalKorepta RafalKorepta mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhsu andrewhsu andrewhsu approved these changes

@RafalKorepta RafalKorepta RafalKorepta approved these changes

Assignees

@0x5d 0x5d

Labels
area/k8s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove unneeded log stmnt in k8s configurator
5 participants
@0x5d @CLAassistant @andrewhsu @RafalKorepta @vbotbuildovich