Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handling members with group.instance.id set i.e. static members #4684

Merged
merged 16 commits into from
May 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/v/kafka/client/test/fixture.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ namespace kc = kafka::client;
class kafka_client_fixture : public redpanda_thread_fixture {
public:
void restart() {
app.shutdown();
shutdown();
app_signal = std::make_unique<::stop_signal>();
ss::smp::invoke_on_all([this] {
auto& config = config::shard_local_cfg();
config.get("disable_metrics").set_value(false);
Expand All @@ -29,8 +30,7 @@ class kafka_client_fixture : public redpanda_thread_fixture {
app.check_environment();
app.configure_admin_server();
app.wire_up_services();
::stop_signal app_signal;
app.start(app_signal);
app.start(*app_signal);
}

kc::client make_client() { return kc::client{proxy_client_config()}; }
Expand Down
2 changes: 2 additions & 0 deletions src/v/kafka/protocol/leave_group.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ struct leave_group_request final {

// set during request processing after mapping group to ntp
model::ntp ntp;
// additional context, set in decode
api_version version;

void encode(response_writer& writer, api_version version) {
data.encode(writer, version);
Expand Down
1 change: 1 addition & 0 deletions src/v/kafka/protocol/schemata/generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
},
},
"MemberId": ("kafka::member_id", "string"),
"GroupInstanceId": ("kafka::group_instance_id", "string"),
},
"AddPartitionsToTxnRequestData": {
"Topics": {
Expand Down
Loading