tests: fix BadLogLines for "No such file" messages #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assert originally went in when we wanted to check we weren't grepping on a nonexistent path, but it turns out there are certain conditions under which Redpanda can emit matching log messages, which we should be handling as the usual BadLogLines, not asserting on.
|
CI failure is one of the FranzGoVerifiableWithSiTest which has since moved into scale_tests/ |
NyaliaLui
approved these changes
May 16, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
This assert originally went in when we wanted to check
we weren't grepping on a nonexistent path, but it turns
out there are certain conditions under which Redpanda
can emit matching log messages, which we should be
handling as the usual BadLogLines, not asserting on.
Release notes