Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed serialization of group tombstones #4901

Merged
merged 7 commits into from
Jun 3, 2022
Merged

Fixed serialization of group tombstones #4901

merged 7 commits into from
Jun 3, 2022

Commits on Jun 1, 2022

  1. k/gr_recovery_consumer: improved exception message 

    Signed-off-by: Michal Maslanka <michal@vectorized.io>
    @mmaslankaprv
    mmaslankaprv committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    d32ac70 View commit details
    Browse the repository at this point in the history

  2. k/group: do not serialize key iobuf as iobuf 

    When serialized a key is already an iobuf. Wrapping it with another
serialization layer is incorrect as it introduces additional size field
in the binary format that deserializer doesn't expect.

Signed-off-by: Michal Maslanka <michal@vectorized.io>
    @mmaslankaprv
    mmaslankaprv committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    412dbcd View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. k/group_metadata: added compatibility with incorrectly serialized keys 

    Previously in redpanda we had an error leading to wrapping tombstone
record keys with an iobuf serialization envelope. In order to provide
compatibility and be able to read keys wrapped with an additional iobuf
we introduce this check. The check validates the key version being in
allowed range. Otherwise we try to unwrap a key from iobuf.

Signed-off-by: Michal Maslanka <michal@vectorized.io>
    @mmaslankaprv
    mmaslankaprv committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    19ee4eb View commit details
    Browse the repository at this point in the history

  2. k/group_metadata: added tests validating serialization of metadata key 

    Added test validating a compatibility of decoding group metadata keys
wrapped in iobuf.

Signed-off-by: Michal Maslanka <michal@vectorized.io>
    @mmaslankaprv
    mmaslankaprv committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    a352a17 View commit details
    Browse the repository at this point in the history

  3. tests: added dead group recovery test 

    Signed-off-by: Michal Maslanka <michal@vectorized.io>
    @mmaslankaprv
    mmaslankaprv committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    48c2e7e View commit details
    Browse the repository at this point in the history

  4. tests/rpk: added group_delete method 

    Signed-off-by: Michal Maslanka <michal@vectorized.io>
    @mmaslankaprv
    mmaslankaprv committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    fdb6e72 View commit details
    Browse the repository at this point in the history

  5. tests/migration_test: extended test to validate tombstones migration 

    Added additional consumer group to migration test. The group is deleted
during the test. Group deletion triggers a code path that involves
reading and interpreting group tombstones.

Signed-off-by: Michal Maslanka <michal@vectorized.io>
    @mmaslankaprv
    mmaslankaprv committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    73566a6 View commit details
    Browse the repository at this point in the history