operator: Add dynamic hooks for graceful restarts #4907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
changed the title
| PostStart: r.getPostStartHook(), | ||
| PreStop: r.getPreStopHook(), | ||
| }, | ||
| ReadinessProbe: r.getReadinessProbe(), |
There was a problem hiding this comment.
It would be nice if commit message include the reason why readiness probe is introduced. The initial design was assuming that unready brokers should be exposed regardless of the internal state. Kafka clients would retries if necessary. If this is added I would assume we need to change the Service definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
This introduces dynamic hooks that allow to handle both managed (e.g. upgrades) and unmanaged (k8s upgrades, node draining etc.) restarts.
Opening as draft as it needs some discussion with core/cloud before merging.
More details later...