cluster: drop redundant set_status config updates #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a follower isn't seeing controller log updates promptly, it may issue many set_status RPCs while it's waiting. The controller leader should not turn all of these into log writes: if the status of the node already matches what it is reporting, then do not write anything. Fixes redpanda-data#4923
On a healthy system, we do want to send set_status RPCs as soon as we're ready. However, if the controller log updates are not being seen promptly, this would lead to the follower spamming the controller leader with very many set_status RPCs in a tight loop. Nodes will still send their status immediately when a config change occurs: this change only effects the behaviour if _another_ config change occurs while it is reporting status from the first change: in this case the follower will wait 5 seconds before sending its next status RPC. Related redpanda-data#4923
|
TopicRecoveryTest.test_fast2 is likely a variant of #4886, but certainly unrelated to this change. |
jcsp
requested review from
dotnwat,
mmaslankaprv,
ztlpn and
VadimPlh
as code owners
mmaslankaprv
approved these changes
May 27, 2022
|
/backport v22.1.x |
This was referenced May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Fixes #4923
Release notes
Improvements