non-functional changes spotted in review post-merge #4938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to redpanda-data#4916 for some things found in review, and more.
constexpr already implies inline, so this patch removes the inline tag.
andrwng
requested review from
VadimPlh,
BenPope,
mmaslankaprv,
ztlpn,
jcsp,
rystsov and
a team
as code owners
andrwng
changed the title
BenPope
approved these changes
May 26, 2022
dotnwat
approved these changes
May 26, 2022
|
Failure is #4887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
This includes some non-functional changes noticed in PRs that have already been merged.
Release notes