Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.1.x] cluster: drop redundant set_status config updates #4959

Merged

Commits on May 27, 2022

  1. cluster: drop redundant set_status config updates

    If a follower isn't seeing controller log updates
    promptly, it may issue many set_status RPCs while
    it's waiting.  The controller leader should not
    turn all of these into log writes: if the status
    of the node already matches what it is reporting,
    then do not write anything.
    
    Fixes redpanda-data#4923
    
    (cherry picked from commit 0a2b991)
    jcsp authored and vbotbuildovich committed May 27, 2022
    Configuration menu
    Copy the full SHA
    c4bbce8 View commit details
    Browse the repository at this point in the history
  2. cluster: wait between config set_status RPCs

    On a healthy system, we do want to send set_status
    RPCs as soon as we're ready.  However, if the controller
    log updates are not being seen promptly, this would lead
    to the follower spamming the controller leader with
    very many set_status RPCs in a tight loop.
    
    Nodes will still send their status immediately when
    a config change occurs: this change only effects the
    behaviour if _another_ config change occurs while
    it is reporting status from the first change: in this
    case the follower will wait 5 seconds before sending
    its next status RPC.
    
    Related redpanda-data#4923
    
    (cherry picked from commit 3b1e56e)
    jcsp authored and vbotbuildovich committed May 27, 2022
    Configuration menu
    Copy the full SHA
    53d2222 View commit details
    Browse the repository at this point in the history