Do not restart cluster when scaling up #4964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
force-pushed
the
av/scale-up-restart
branch
4 times, most recently
from
29d33a5
to
c0fe3fb
Compare
alenkacz
force-pushed
the
av/scale-up-restart
branch
from
c0fe3fb
to
7b4c5e7
Compare
alenkacz
force-pushed
the
av/scale-up-restart
branch
from
7b4c5e7
to
1f2496c
Compare
nicolaferraro
requested changes
May 31, 2022
| @@ -120,6 +120,7 @@ func (c *GlobalConfiguration) GetNodeConfigurationHash() (string, error) { | |||
| clone := *c | |||
| // clean any cluster property from config before serializing | |||
| clone.ClusterConfiguration = nil | |||
| removeIgnoredFields(&clone) | |||
There was a problem hiding this comment.
I think probably we don't need to clone the object, but the code above seems to suggest we do a deep copy, while in practice it's doing a shallow one and the object is probably being modified
| func removeIgnoredFields(clone *GlobalConfiguration) { | ||
| // ignore seeds for hash computation so that changes in this field don't | ||
| // trigger cluster restats | ||
| clone.NodeConfiguration.Redpanda.SeedServers = []config.SeedServer{} |
There was a problem hiding this comment.
I think there are other cases where we iterate over the replicas to create urls, such as for panda proxy and schema registry
| existingCluster.Spec.Replicas = &repliasP1 | ||
| Expect(k8sClient.Update(context.Background(), &existingCluster)).Should(Succeed()) | ||
| newConfigMapHash := sts.Annotations[res.ConfigMapHashAnnotationKey] | ||
| Expect(newConfigMapHash).Should(Equal(configMapHash)) |
There was a problem hiding this comment.
Better using Consistently(func ...) in this case, even if it takes more time
There was a problem hiding this comment.
Also the sts is not reloaded
|
Closing this as it will not be relevant for the v2 operator: https://github.com/redpanda-data/redpanda/tree/operator-v2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Currently when scaling up, we always update seed servers and that update triggered restart of the whole cluster. That's unnecessary, it's only important that there's at least one node up from all seeds, there does not have to be all listed.
This PR changes the current behavior so the algorithm computing hashes to not include seeds - so change in seeds will never trigger restart. Considering the way how clusters are scaled up and down right now, this is correct behavior.
We cannot backport this as it triggers restart of the whole cluster because it changes the existing hashes.
Fixes #ISSUE-NUMBER, Fixes #ISSUE-NUMBER, ...
Release notes
Improvements