[v22.1.x] admin: reject maintenance mode req on 1 node cluster #4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a single node cluster puts its only node in maintenance mode, then there is no node elegible to become controller leader, and all further progress is stopped. Fixes redpanda-data#4338 (cherry picked from commit b970b2d)
If a system got into the bad state of issue redpanda-data#4338, then their cluster is broken until we replay the controller log _without_ putting the node into maintenance mode. Related redpanda-data#4338 (cherry picked from commit 20f3597)
jcsp
requested review from
dotnwat,
mmaslankaprv,
ztlpn and
VadimPlh
as code owners
|
failure is #4887 test_id: rptest.tests.topic_recovery_test.TopicRecoveryTest.test_size_based_retention |
dotnwat
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Backport #4921
Release notes
Improvements