Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v/rpc: use std::constructible_from when appropriate #5145

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Jun 16, 2022

Cover letter

for better readability

Signed-off-by: Kefu Chai [email protected]

Release notes

  • none

for better readability

Signed-off-by: Kefu Chai <[email protected]>
@tchaikov
Copy link
Contributor Author

tchaikov commented Jun 16, 2022

not sure if tiny changes like this are appropriate. if not, i'd be happy to close this one =)

Copy link
Contributor

@jcsp jcsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me (I hadn't heard of constructible_from before, still learning all the C++20 bits!)

@tchaikov
Copy link
Contributor Author

same here! still crunching the ranges =)

@tchaikov
Copy link
Contributor Author

@jcsp hi John, is this change pending on another reviewer or a round of internal test?

Just wanted to understand the process in general.

@mmaslankaprv mmaslankaprv merged commit f2401e4 into redpanda-data:dev Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants