Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregate metrics to reduce cardinality #5166

Merged
merged 10 commits into from
Jul 4, 2022
Merged

Aggregate metrics to reduce cardinality #5166

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
540d86f
metrics: Allow configuration of default aggregations
BenPope Jun 6, 2022
71ae328
metrics: archival: default aggregations
Jun 24, 2022
df211e2
metrics: cluster: default aggregations
Jun 24, 2022
91e7873
metrics: kafka: default aggregations
Jun 24, 2022
551a303
metrics: rpc: default aggregations
Jun 24, 2022
d54016e
metrics: rpc: default aggregations
Jun 23, 2022
bf969bb
metrics: raft: default aggregations
Jun 23, 2022
39db1cf
metrics: raft: default aggregations
Jun 23, 2022
90b8ffb
metrics: storage: default aggregations
Jun 24, 2022
1a27b58
metrics: pandaproxy: default aggregations
Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion tools/rpcgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
// This file is autogenerated. Manual changes will be lost.
#pragma once

#include "config/configuration.h"
#include "reflection/adl.h"
#include "rpc/types.h"
#include "rpc/parse_utils.h"
Expand Down Expand Up @@ -86,13 +87,18 @@ class failure_probes;
std::vector<ss::metrics::label_instance> labels{
service_label("{{service_name}}"),
method_label("{{method.name}}")};
auto aggregate_labels
= config::shard_local_cfg().aggregate_metrics()
? std::vector<sm::label>{sm::shard_label, method_label}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's neat

: std::vector<sm::label>{};
_metrics.add_group(
prometheus_sanitize::metrics_name("internal_rpc"),
{sm::make_histogram(
"latency",
[this] { return _methods[{{loop.index-1}}].probes.latency_hist().seastar_histogram_logform(); },
sm::description("Internal RPC service latency"),
labels)});
labels)
.aggregate(aggregate_labels)});
}
{%- endfor %}
}
Expand Down