Factor out rate testing util for quota testing, etc. #5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajfabbri
force-pushed
the
write-rej-followup
branch
from
40762f0
to
7f059e9
Compare
Used here for asserting that producer rate goes to zero when we block writes due to low space. Turns out this is also a handy utility for testing other features like quotas. Generalize and factor out a new test helper class ExpectRate. See the docstring for implementation details.
ajfabbri
force-pushed
the
write-rej-followup
branch
from
7f059e9
to
024eab8
Compare
|
Force pushes were rebase on dev + formatting fix. |
dotnwat
approved these changes
Jun 28, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used here for asserting that producer rate goes to zero when we block
writes due to low space. Turns out this is also a handy utility for
testing other features like quotas.
Generalize and factor out a new test helper class ExpectRate. See the
docstring for that this for implementation details.
Release notes