ducky: fix test_deletion_stops_move ci-failure #5204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
approved these changes
Jun 23, 2022
dotnwat
reviewed
Jun 28, 2022
| @@ -174,7 +174,7 @@ def _get_stable_configuration( | |||
| self.redpanda.logger.debug(f"doesn't have leader") | |||
| return None | |||
| if last_leader < 0: | |||
| last_leader = meta["leader_id"] | |||
| last_leader = int(meta["leader_id"]) | |||
There was a problem hiding this comment.
if meta["leader_id"] < 0 already exists above suggesting the type is numeric. why is conversion necessary?
Comment on lines
-260
to
+262
| wait_until( | ||
| return wait_until_result( |
There was a problem hiding this comment.
@rystsov why did this change? wait_until_result is intended for when the return value of the predicate is desired by the caller of wait_until, but here it is thrown away.
There was a problem hiding this comment.
Sorry for the noise! I didn't see the return :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Add check that a cluster has a leader before performing an action.
Fixes #5189
Release notes