Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.1.x] rpk: fix ipv6 parsing of ParseHostMaybeScheme function #5230

Merged
merged 1 commit into from
Jun 26, 2022
Merged

[v22.1.x] rpk: fix ipv6 parsing of ParseHostMaybeScheme function #5230

merged 1 commit into from
Jun 26, 2022

Conversation

vbotbuildovich
Copy link
Collaborator

Backport from pull request: #4777.
Fixes #5229,

@vbotbuildovich vbotbuildovich added this to the v22.1.x-next milestone Jun 24, 2022
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jun 24, 2022
@vbotbuildovich vbotbuildovich requested a review from 0x5d June 24, 2022 16:05
@r-vasquez r-vasquez marked this pull request as ready for review June 24, 2022 16:06
@r-vasquez
Copy link
Contributor

Unrelated failures:

#2484

#4887

BenPope
BenPope approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would have been nice to have had some tests.

@twmb twmb merged commit 61f46f3 into redpanda-data:v22.1.x Jun 26, 2022
@BenPope BenPope modified the milestones: v22.1.x-next, v22.1.5 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPope BenPope BenPope approved these changes

@0x5d 0x5d Awaiting requested review from 0x5d 0x5d is a code owner

@twmb twmb Awaiting requested review from twmb twmb is a code owner

@LenaAn LenaAn Awaiting requested review from LenaAn

Assignees
No one assigned
Labels
area/rpk kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v22.1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@vbotbuildovich @r-vasquez @BenPope @twmb