Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release kafka request resources at the right time #5280

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Release kafka request resources at the right time #5280

wants to merge 3 commits into from

Commits on Jun 29, 2022

  1. Clarify behavior of process_next_response 

    The behavior of process_next_response is worth clarifying as the
returned future does not nececessarily wait for all enqueued respones
to be finished before resolving.

We also rename the method to better reflect its purpose.
    @travisdowns
    travisdowns committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    fcfa9ac View commit details
    Browse the repository at this point in the history

  2. Add comment to session resources

    @travisdowns
    travisdowns committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    e483188 View commit details
    Browse the repository at this point in the history

  3. Release resources after the response is written 

    Currently we release resources after the response is enqueued
in connection_context and response processing is called, but it
may not have been sent at this point as we require in-order responses
but second-stage processing may happen out of order.

In this change, we instead tunnel the resource object through to
the place where the response is written, and release it there.

FIxes redpanda-data#5278.
    @travisdowns
    travisdowns committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    c6578b4 View commit details
    Browse the repository at this point in the history