tests: fix test_changing_topic_retention_with_restart #5331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
force-pushed
the
issue-2406-retention-policy-test
branch
from
a2c0ab3
to
f35e164
Compare
BenPope
reviewed
Jul 4, 2022
VladLazar
reviewed
Jul 4, 2022
Nope, it's this constant in the source: While I was updating this I added a reference to the comment in the test. |
This test was assuming that segment sizes apply exactly, but they are actually subject to a +/- 5% jitter. To reliably remove the expected number of segments, we must set our retention bytes to 5% less than the amount we really expect to retain. Fixes redpanda-data#2406
jcsp
force-pushed
the
issue-2406-retention-policy-test
branch
from
f35e164
to
20949e3
Compare
dotnwat
approved these changes
Jul 4, 2022
|
CI failures are two issues from partition movement cancellation: |
|
@jcsp looks like this will backport to v22.1.x, v21.11.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
This test was assuming that segment sizes apply exactly,
but they are actually subject to a +/- 5% jitter. To reliably
remove the expected number of segments, we must set our retention
bytes to 5% less than the amount we really expect to retain.
Fixes #2406
Release notes