Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: remove demos #5352

Merged
merged 2 commits into from
Jul 6, 2022
Merged

rpc: remove demos #5352

merged 2 commits into from
Jul 6, 2022

Conversation

dotnwat
Copy link
Member

@dotnwat dotnwat commented Jul 6, 2022

Cover letter

Removes the demos: raft/tron and rpc/demo. These are still available in git if needed in the future, but aren't used any integration tests, haven't been updated except to keep them compiling in a long time, and now are adding more maintenance cost in terms of supporting conversion of rpc message types for which each demo have multiple.

Release notes

  • None

Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Copy link
Contributor

@emaxerrno emaxerrno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wrote them as a faster way to iterate on the gen'ed code. i don't think they serve a need now.

below some background for future dev

  • the xor hash reduces lookup tables by 1 hop
  • the hash on the method makes it xor-able w/ the service name
  • having the methods on a stack allocated array is the fastest thing we could benchmark (all tricks from boost small vector to absl hash tables, even facebook f14 tables and std::vectors were tested - there is a long long thread in the smf rpc issue list)
  • the compiler code-gening the jump table (see the switch/case statement) - from the xor hashes proved to be the friendliest.
  • just wanted to record the decisions that differ from seastar, and are closer to the smfrpc suite.

@dotnwat
Copy link
Member Author

dotnwat commented Jul 6, 2022

having the methods on a stack allocated array is the fastest thing we could benchmark (all tricks from boost small vector to absl hash tables, even facebook f14 tables and std::vectors were tested - there is a long long thread in the smf rpc issue list)

fastest rpc in the west

@jcsp jcsp merged commit 22ff2dc into redpanda-data:dev Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants