Node operations fuzzy improvements #5360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
requested review from
dotnwat,
NyaliaLui,
ztlpn and
VadimPlh
as code owners
andrwng
reviewed
Jul 6, 2022
| return true; | ||
| } | ||
| // update may be finished by a node that was added to replica set | ||
| if (!has_local_replicas(_self, previous_replicas)) { |
There was a problem hiding this comment.
nit: just looking at this method, this comment doesn't quite match up with the behavior. Could you add a note that it's expected that one of current_replicas is local?
Ah, I see there's another PR out for it. Sorry for the noise. The fuzz test changes LGTM. |
Fixed dispatching update_finished command when no replicas were added to the replica set. Previously when no replicas were added to the replica set there was no node that would pass the condition allowing it to dispatch update finished command. This way partition reconfiguration never finished causing chaos-tests to fail. Signed-off-by: Michal Maslanka <[email protected]>
Added test validating if we can shrink raft group replica set. Signed-off-by: Michal Maslanka <[email protected]>
As we are already using admin operations fuzzer to execute admin day-2 operations we may skip creating/deleting topics explicitly Signed-off-by: Michal Maslanka <[email protected]>
Added `add_no_wait` operation to nodes operations fuzzy test. The add no wait does not wait for the node to be populated with partitions before executing next operation, this way we are giving decommissioning a change to be executed before addition will be finished therefore triggering move cancellation code path. Signed-off-by: Michal Maslanka <[email protected]>
Signed-off-by: Michal Maslanka <[email protected]>
Signed-off-by: Michal Maslanka <[email protected]>
mmaslankaprv
force-pushed
the
node-operations-fuzzy-improvements
branch
from
eae5fc9
to
3795ed6
Compare
andrwng
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Describe in plain language the motivation (bug, feature, etc.) behind the change in this PR and how the included commits address it.
Fixes #ISSUE-NUMBER, Fixes #ISSUE-NUMBER, ...
Release notes