Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partition autobalancer planner cancel movement to unavailable nodes #5365

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Partition autobalancer planner cancel movement to unavailable nodes #5365

merged 4 commits into from
Jul 19, 2022

Conversation

ZeDRoman
Copy link
Contributor

@ZeDRoman ZeDRoman commented Jul 6, 2022 •
edited by mmedenjak
Loading

Fixes: #5330

@ZeDRoman ZeDRoman force-pushed the partition-autobalancer-planner branch from b0a249b to 619b036 Compare July 6, 2022 16:19
@ZeDRoman ZeDRoman changed the title Partition autobalancer planner calncel movement to unavailable nodes Partition autobalancer planner cancel movement to unavailable nodes Jul 6, 2022
@mmedenjak mmedenjak added the kind/enhance New feature or request label Jul 7, 2022
ztlpn
ztlpn reviewed Jul 8, 2022
View reviewed changes
src/v/cluster/partition_balancer_types.h Outdated Show resolved Hide resolved
src/v/cluster/partition_balancer_planner.cc Outdated Show resolved Hide resolved
@ZeDRoman ZeDRoman force-pushed the partition-autobalancer-planner branch 3 times, most recently from 7f29bca to aa5a1cb Compare July 18, 2022 13:41
@ZeDRoman ZeDRoman marked this pull request as ready for review July 18, 2022 14:27
ztlpn
ztlpn previously approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@ztlpn ztlpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, but otherwise good to go I think. Would be great to have a ducktape test that exercises this code path.

src/v/cluster/partition_balancer_planner.cc Outdated Show resolved Hide resolved
src/v/cluster/partition_balancer_planner.cc Outdated Show resolved Hide resolved
@ZeDRoman ZeDRoman force-pushed the partition-autobalancer-planner branch from aa5a1cb to 0cfcd63 Compare July 19, 2022 09:02
@ZeDRoman ZeDRoman force-pushed the partition-autobalancer-planner branch from 143db2c to 4c0db78 Compare July 19, 2022 09:28
@ZeDRoman ZeDRoman requested a review from ztlpn July 19, 2022 09:48
@ZeDRoman
Copy link
Contributor Author

Unit test failure #5466

@ZeDRoman ZeDRoman force-pushed the partition-autobalancer-planner branch from 4c0db78 to 141496f Compare July 19, 2022 12:37
@ztlpn
Copy link
Contributor

ztlpn commented Jul 19, 2022

approved conditional on tests passing

@ZeDRoman ZeDRoman merged commit 66252c6 into redpanda-data:dev Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztlpn ztlpn ztlpn approved these changes

@mmaslankaprv mmaslankaprv Awaiting requested review from mmaslankaprv

@VadimPlh VadimPlh Awaiting requested review from VadimPlh

@dotnwat dotnwat Awaiting requested review from dotnwat

@NyaliaLui NyaliaLui Awaiting requested review from NyaliaLui

Assignees
No one assigned
Labels
area/redpanda kind/enhance New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use partition movement cancellation in partition balancer
3 participants
@ZeDRoman @ztlpn @mmedenjak