rpk tune ducktape tests #5407
Merged
rpk tune ducktape tests #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twmb
reviewed
Jul 8, 2022
We want to make sure that the start/installation path that we guide the user to follow is covered in our CI, running rpk redpanda mode prod is a crucial step before running the tuners.
Tests will be only available in CDT since they rely on the environment and can't be run in a container.
This golden test will allow us to catch when a new tuner is either added or removed from production mode
|
Both errors related to: #4772 |
twmb
reviewed
Jul 13, 2022
| fstrim was disabled in production mode https://github.com/redpanda-data/redpanda/issues/3068 | ||
| """ | ||
| node = self.redpanda.nodes[0] | ||
| rpk = RpkRemoteTool(self.redpanda, node) |
There was a problem hiding this comment.
Can these tests check rpk.tune_fstrim, and below, rpk.transparent_hugepages are false before swapping to true?
This will avoid the (not problematic, but redundant) scenario if THP or fstrim are set to true in mode prod: tune all will check these, so we'll be able to delete these tests.
There was a problem hiding this comment.
(not sure how compelling this comment/question is so feel free to dismiss)
There was a problem hiding this comment.
That's true, we also catch this change in test_config_change_mode_prod
There was a problem hiding this comment.
Right, I was thinking that if one of those is set to true, a person wont know to go into this file and remove these redundant tests
twmb
reviewed
Jul 13, 2022
twmb
approved these changes
Jul 13, 2022
twmb
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Added the following ducktape tests:
The rpk redpanda tune test will only run in Clustered Ducktape since they can't run in a normal containerized environment.
Tested in AWS:
Fixes of #4628
Release notes