tests: mitigate MaintenanceTest failures #5409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The real fix will be to make the leader balancer aware of maintenance mode, but the test has become much more unstable since recent leader balancer changes to do more movements concurrently, so its worth mitigating that. The workaround is to set a short mute timeout so that muting nodes has no real effect, and a short idle timeout so that post-maintenance leader movements happen promptly. Related: redpanda-data#4772
|
Failures are AWSRoleFetchTests, this presumably raced with landing the fix for that. |
ballard26
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
The real fix will be to make the leader balancer aware
of maintenance mode, but the test has become much more
unstable since recent leader balancer changes to do
more movements concurrently, so its worth mitigating
that.
The workaround is to set a short mute timeout so that
muting nodes has no real effect, and a short idle timeout
so that post-maintenance leader movements happen promptly.
Related: #4772
Release notes