kafka: merge remote.readreplica and bucket #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazin
previously approved these changes
Jul 13, 2022
The change is only UX, feature implementation and internal types don't change.
|
Rebased this PR after merging #5242 |
mmedenjak
added
area/cloud-storage
Lazin
approved these changes
Jul 14, 2022
dotnwat
reviewed
Jul 22, 2022
| @@ -33,7 +33,7 @@ | |||
|
|
|||
| namespace kafka { | |||
|
|
|||
| static constexpr std::array<std::string_view, 12> supported_configs{ | |||
There was a problem hiding this comment.
In the commit message:
The change is only UX, feature implementation and internal types don't
change.
That is a good to know, but please remember to describe the changes being made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
The change is only UX, feature implementation and internal types don't
change.
Fixes #5314
UX changes
instead of passing
-c redpanda.remote.readreplica=True -c redpanda.remote.readreplica.bucket=<s3 bucket name>to create a read replica topic, user needs to pass-c redpanda.remote.readreplica=<s3 bucket name>This is not breaking change since the feature is not released yet.
Release notes