tests: re-use installs in upgrade tests #5459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrwng
requested review from
rishabh96b and
bharathv
and removed request for
a team
graphcareful
previously approved these changes
Jul 14, 2022
Tests that use the RedpandaInstaller are bandwidth-intensive and often take several minutes to complete on account of the download of hundreds of MBs worth of tarballs. This commit mitigates this in local ducktape by having all test containers share a single bind mount. The installer now uses a lock file to prevent concurrent operations on the mount (e.g. when downloading binaries, checking to see what binaries exist, etc). With this commit, regardless of whether in local or clustered ducktape, we also no longer get rid of downloaded binaries between test runs. Instead, after a test completes, we just revert any changes to the original binaries, and leave the rest be.
graphcareful
approved these changes
Jul 15, 2022
andrewhsu
reviewed
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Tests that use the RedpandaInstaller are bandwidth-intensive and often
take several minutes to complete on account of the download of hundreds
of MBs worth of tarballs.
This commit mitigates this in local ducktape by having all test
containers share a single bind mount. The installer now uses a lock file
to prevent concurrent operations on the mount (e.g. when downloading
binaries, checking to see what binaries exist, etc).
With this commit, we also no longer get rid of downloaded binaries between
test runs. Instead, after a test completes, we just revert any changes
to the original binaries, and leave the rest be.
This helps mitigate #5417 by significantly reducing the number of installs.
Release notes