Align feature manager's logical versions with v22.1.5 #5481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use feature manager to postpone activating a feature until all nodes in the cluster are updated to avoid a situation in which a node with a newer version uses an updated version of a protocol to communicate with an older version which doesn't understand it. We tend to avoid backporting features but there are cases when we need to do it anyway e.g. when a bug fix introduces a protocol change and we need to use the feature manager to perform a non-interruptive upgrade. When we do it we need to do it very carefully to preserve the feature manager invariant: the series of versions and the definitions of the features must line up perfectly with the history of versions+features in subsequent releases https://vectorizedio.atlassian.net/wiki/spaces/CORE/pages/170491930 However if we the bugfix is added after we already introduced several feature which we don't backport we need to update the dev branch (future release) to be consistent with the minor "backport" release. This change updates the dev to be consistent with v22.1.5 release which contains a bug fix gated by rm_stm_kafka_cache feature flag.
bharathv
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
We use feature manager to postpone activating a feature until all nodes in the cluster are updated to avoid a situation in which a node with a newer version uses an updated version of a protocol to communicate with an older version which doesn't understand it.
We tend to avoid backporting features but there are cases when we need to do it anyway e.g. when a bug fix introduces a protocol change and we need to use the feature manager to perform a non-interruptive upgrade.
When we do it we need to do it very carefully to preserve the feature manager invariant:
However if the bugfix is added after we already introduced several feature which we don't backport we need to update the dev branch (future release) to be consistent with the minor "backport" release.
This change updates the dev to be consistent with v22.1.5 release which contains a bug fix gated by
rm_stm_kafka_cachefeature flag.Release notes