Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: Support listener authN #5482

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Jul 15, 2022

Cover letter

Support the configuration change introduced in #5292

  • Allow per listener authentication to be configured by using the following format: name://host:port|authn
  • Keep the yaml format

UX changes

Support per-listener authentication.

Release notes

Features

  • Allow per listener authentication to be configured by using the following format: name://host:port|authn

@BenPope BenPope force-pushed the rpk-listener-authn branch 2 times, most recently from c05a3eb to 421bb1b Compare July 18, 2022 17:04
@BenPope BenPope marked this pull request as ready for review July 19, 2022 13:00
@BenPope BenPope requested review from twmb, 0x5d, r-vasquez and a team as code owners July 19, 2022 13:00
RafalKorepta
RafalKorepta previously approved these changes Jul 19, 2022
@BenPope
Copy link
Member Author

BenPope commented Jul 19, 2022

CI failure is #5474

`NamedAuthNSocketAddress` is a clone of `NamedSocketAddress` with
an additional field, `AuthN` to support the `authentication_method`
on the kafka listener, introduced in redpanda-data#5292.

Allow parsing the form `scheme://host:port|authn`
Allow unmarshalling from YAML

Signed-off-by: Ben Pope <[email protected]>
@BenPope
Copy link
Member Author

BenPope commented Jul 19, 2022

Rebased due to conflict from: #5513

@BenPope BenPope merged commit 5b0b0eb into redpanda-data:dev Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants