tests: add mixed-version test for sending Raft snapshot RPCs #5488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| log_allow_list=LOG_ALLOW_LIST + | ||
| MixedVersionWorkloadRunner.ALLOWED_LOGS) | ||
| def test_recover_during_upgrade(self): | ||
| def _run_recovery(src_node, dst_node): |
|
Rebased to get the adaptive RPC serialization changes |
This commit adds a test harness that runs workloads on a partially upgraded cluster. The goal here is to ensure we exercise RPC serialization methods when the versions between the sender and receiver on mismatched. To that end, the harness expects to be provided a workload that spurs RPCs in a deterministic direction: - We first perform a partial upgrade, - then run the workload between an upgraded node and non-upgraded node, - then run the workload in the opposite direction, - then do a partial rollback and repeat, - then proceed with a full upgrade and repeat.
This adds a test that installs snapshots across mixed versions, testing compatibility of the respective RPCs when there is a version mismatch. I reused an existing test, pulling out the guts into a test base class, though I tweaked some retry intervals to speed the test up.
|
Rebased to get the adaptive RPC serialization changes |
|
Test failure appears to be #4772 |
dotnwat
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
This PR adds a test harness that runs workloads on a partially upgraded cluster. The goal here is to ensure we exercise RPC serialization methods when the versions between the sender and receiver on mismatched.
To that end, the harness expects to be provided a workload that spurs RPCs in a deterministic direction:
I intend on using this harness to ensure we have coverage for our RPCs between nodes of different versions. To start, this PR includes a test that exercises RPCs involved in installing a snapshot.
Release notes