k/tests: wait for coordinator of correct group id #5496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmedenjak
added
kind/bug
NyaliaLui
added
the
ci-repeat-5
vbotbuildovich
removed
the
ci-repeat-5
|
Added ci-repeat-5 since this PR fixes ci-failures |
|
Good call @NyaliaLui. I think the failure may have triggered again: https://buildkite.com/redpanda/redpanda/builds/12747#018217f3-7504-4609-854e-e27bcd0289d1/6-5439 |
When broker returns `not_coordinator` error client should retry. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
added
the
ci-repeat-5
vbotbuildovich
removed
the
ci-repeat-5
dotnwat
approved these changes
Jul 22, 2022
dlex
reviewed
Jul 26, 2022
| = client.dispatch(std::move(req), kafka::api_version(5)).get0(); | ||
| BOOST_REQUIRE( | ||
| resp.data.error_code == kafka::error_code::none | ||
| || resp.data.error_code == kafka::error_code::not_coordinator); |
There was a problem hiding this comment.
The case when error_code == none && member_id == unknown_member_id was a test failure before, and now it will cause retries. Should it be an immediate failure instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After changing default number of partitions for
__consumer_offsetstopic we need to wait for particular group coordinator before requesting
consumer to join the group.
Fixes: #5495
Fixes: #5466