Accumulated miscellaneous changes #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Colocating the code generator with the rpc framework is logical, but also results in a smoother integration with Meson build system which is far more opinionated than cmake which doesn't care at all. Signed-off-by: Noah Watkins <[email protected]>
This changes makes the code generator easier to integrate into Meson which wants to have far more control over output file paths than cmake. Signed-off-by: Noah Watkins <[email protected]>
dotnwat
requested review from
graphcareful,
mmaslankaprv,
jcsp,
NyaliaLui,
a team and
BenPope
as code owners
dotnwat
commented
Jul 19, 2022
| schema_path = pathlib.Path(sys.argv[2]) | ||
| src = (outdir / schema_path.name).with_suffix(".cc") | ||
| hdr = (outdir / schema_path.name).with_suffix(".h") | ||
| assert len(sys.argv) == 4 |
|
Failure is #5474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
A few misc. changes that accumulated during the Meson work.
Release notes