Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk redpanda config set: improve setting arrays #5522

Merged
merged 1 commit into from
Jul 20, 2022
Merged

rpk redpanda config set: improve setting arrays #5522

merged 1 commit into from
Jul 20, 2022

Commits on Jul 20, 2022

  1. rpk redpanda config set: improve setting arrays

    Recent rpk improvements now initialize index 0 of a slice if the key we
    are setting is deeply inside the slice. e.g., foo.bar.baz would
    initialize bar[0] to set baz. However, it was not possible to set
    foo.bar[1]. This change fixes that. We also allow setting one past the
    end of an array to extend it: if foo.bar[0] exists, then foo.bar[1].baz
    adds to the array.
    
    Old rpk never had the ability to set an array key to a single value that
    was not wrapped in brackets. For example, `foo.bar = "baz"` would not
    work if bar was an array. Now, we use / initialize element 0 and set
    that.
    
    Fixes #2958
    Fixes #5498
    Fixes #5264
    twmb committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    0604ee2 View commit details
    Browse the repository at this point in the history