Transactions: remove expired abort indexes #5556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajfabbri
reviewed
Jul 21, 2022
ajfabbri
reviewed
Jul 21, 2022
ajfabbri
reviewed
Jul 21, 2022
ajfabbri
reviewed
Jul 21, 2022
ajfabbri
reviewed
Jul 21, 2022
ajfabbri
reviewed
Jul 21, 2022
ajfabbri
reviewed
Jul 21, 2022
ajfabbri
reviewed
Jul 21, 2022
ajfabbri
reviewed
Jul 21, 2022
ajfabbri
suggested changes
Jul 21, 2022
dotnwat
reviewed
Jul 22, 2022
mmedenjak
added
kind/enhance
bharathv
reviewed
Jul 26, 2022
Once a log was evicted up to an offset X it's wasteful to store abort indexes covering the offsets before X (the abort index is used only for the existing offsets). The commit drops the expired abort indexes during the snapshot procedure.
rystsov
force-pushed
the
truncate-persisted-stm
branch
from
707fb68
to
0ba5edc
Compare
|
Build failure: #5868 |
dotnwat
requested changes
Aug 6, 2022
There was a problem hiding this comment.
@rystsov PR looks good to me!
but I think there is a potential race condition that could lead to a segfault. where the race is possible or is protected against some how is not clear. could you take a look? i left a comment with the concern.
rystsov
force-pushed
the
truncate-persisted-stm
branch
from
0ba5edc
to
fb64e73
Compare
5 tasks
rystsov
force-pushed
the
truncate-persisted-stm
branch
from
fb64e73
to
b3fd299
Compare
not anymore |
bharathv
reviewed
Aug 16, 2022
rystsov
force-pushed
the
truncate-persisted-stm
branch
from
b3fd299
to
adcc440
Compare
dotnwat
approved these changes
Aug 19, 2022
ajfabbri
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Once a log was evicted up to an offset X it's wasteful to store abort indexes covering the offsets before X (the abort index is used only for the existing offsets). The commit drops the expired abort indexes during the snapshot procedure.
Release notes