Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: add seastar_memory and serde to log list #5557

Merged
merged 1 commit into from
Jul 22, 2022
Merged

rpk: add seastar_memory and serde to log list #5557

merged 1 commit into from
Jul 22, 2022

Conversation

r-vasquez
Copy link
Contributor

Cover letter

We were missing these 2 logs and confirmed that works:

$ rpk redpanda admin config log-level set --host localhost:9644 all -l info -e 0    
SUCCESSES
admin_api_server
archival
archival-ctrl
assert
cloud_storage
cluster
compaction_ctrl
compression
coproc
dns_resolver
exception
fault_injector
http
httpd
io
json
kafka
kvstore
metrics-reporter
offset_translator
pandaproxy
raft
redpanda::main
rpc
s3
scheduler
scollectd
seastar
seastar_memory
security
serde
storage
storage-gc
syschecks
tx

logs:

Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {admin_api_server}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {archival}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {archival-ctrl}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {assert}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {cloud_storage}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {cluster}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {compaction_ctrl}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {compression}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {coproc}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {dns_resolver}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {exception}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {fault_injector}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,182 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {http}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {httpd}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {io}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {json}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {kafka}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {kvstore}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {metrics-reporter}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {offset_translator}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {pandaproxy}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {raft}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {redpanda::main}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {rpc}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {s3}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {scheduler}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {scollectd}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {seastar}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {seastar_memory}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {security}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {serde}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,183 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {storage}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,184 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {storage-gc}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,184 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {syschecks}: info -> info
Jul 21 13:28:28 fedora rpk[24613]: INFO  2022-07-21 13:28:28,184 [shard 0] admin_api_server - admin_server.cc:709 - Set log level for {tx}: info -> info

Release notes

  • rpk: add seastar_memory and serde to the list of loggers you can modify using rpk redpanda admin config log-level all

@r-vasquez r-vasquez requested review from twmb and 0x5d as code owners July 21, 2022 18:34
twmb
twmb approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@twmb twmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note this is a quick fix for v22.2 until we work on the real auto-discovery fix)

@emaxerrno
Copy link
Contributor

@r-vasquez we should do some tiktok 30 second screens of our CLI
so good.

@r-vasquez
Copy link
Contributor Author

Failure in https://buildkite.com/redpanda/redpanda/builds/12872#018222e4-e811-40de-9dc1-5bd5569b1042 is: #4772

@r-vasquez r-vasquez merged commit 578499a into redpanda-data:dev Jul 22, 2022
@r-vasquez r-vasquez deleted the update-logger-list branch July 22, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twmb twmb twmb approved these changes

@0x5d 0x5d Awaiting requested review from 0x5d

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-vasquez @emaxerrno @twmb