schema_registry: Return schemaType for /schemas/ids/<id> #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the schema type is not avro, then set schemaType field in the response. Signed-off-by: Ben Pope <[email protected]>
The `schemaType` is now returned if it's not avro. Signed-off-by: Ben Pope <[email protected]>
jrkinley
reviewed
Jul 22, 2022
jrkinley
approved these changes
Jul 22, 2022
VladLazar
reviewed
Jul 22, 2022
| @@ -2,7 +2,7 @@ | |||
| "swagger": "2.0", | |||
| "info": { | |||
| "title": "Pandaproxy Schema Registry", | |||
| "version": "1.0.0" | |||
| "version": "1.0.1" | |||
There was a problem hiding this comment.
Just curious: is this version type exposed anywhere?
There was a problem hiding this comment.
curl -s localhost:8081/v1 | jq '.info.version'
"1.0.1"
There was a problem hiding this comment.
Also, I should set up a better home for the swagger
VladLazar
approved these changes
Jul 22, 2022
|
/backport v22.1.x |
|
/backport v21.11.x |
This was referenced Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
If the schema type is not avro, then set
schemaTypefield in the response.Signed-off-by: Ben Pope [email protected]
Fixes #3633 (fix it even more)
Fixes #5576
Release notes
Improvements
GET /schemas/ids/<id>now returnsschemaTypeif the type is not avro.