Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/KStreams: re-enable Wikipedia test #5615

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

NyaliaLui
Copy link
Contributor

@NyaliaLui NyaliaLui commented Jul 25, 2022

Cover letter

This test was disabled due to #2889 but a lot has changed since then.
Re-enable the test with ok_to_fail to see if it continues to fail.

Release notes

  • none

@NyaliaLui NyaliaLui requested a review from a team as a code owner July 25, 2022 14:51
@NyaliaLui NyaliaLui self-assigned this Jul 25, 2022
@NyaliaLui NyaliaLui requested review from ivotron and removed request for a team July 25, 2022 14:51
@jcsp
Copy link
Contributor

jcsp commented Jul 25, 2022

It looks like this references a ducktape-debug branch - did you mean to open this as a draft?

Otherwise the substance of the change looks fine.

@NyaliaLui
Copy link
Contributor Author

It looks like this references a ducktape-debug branch - did you mean to open this as a draft?

Otherwise the substance of the change looks fine.

@jcsp
the ducktape-debug branch adds a little more logging to another Ci-failure test KStreamsPageView here. It can go in a separate PR if that's preferable.

ajfabbri
ajfabbri previously approved these changes Jul 27, 2022
Copy link
Contributor

@ajfabbri ajfabbri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending CI)

@jcsp
Copy link
Contributor

jcsp commented Jul 28, 2022

the ducktape-debug branch adds a little more logging to another Ci-failure test KStreamsPageView #4637. It can go in a separate PR if that's preferable.

When we pull from git we should pull a sha1 to make it deterministic, so I think the thing to do is to update this PR to pull the sha1 you want, instead of a named branch. That way you don't end up having to create multiple named branches, you can just add your commits to the main branch and old/new versions of tests will pull from the sha they expect.

This test was disabled due to redpanda-data#2889 but a lot has changed since then.
Re-enable the test with ok_to_fail to see if it continues to fail.
@NyaliaLui
Copy link
Contributor Author

CI Failures are instances of
#5695
#5710

@NyaliaLui NyaliaLui requested a review from ajfabbri July 28, 2022 16:42
@jcsp jcsp merged commit a3fab5b into redpanda-data:dev Jul 28, 2022
@NyaliaLui NyaliaLui deleted the kstreams-re-enable-wikipedia branch March 15, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants