-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/KStreams: re-enable Wikipedia test #5615
tests/KStreams: re-enable Wikipedia test #5615
Conversation
It looks like this references a Otherwise the substance of the change looks fine. |
@jcsp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending CI)
When we pull from git we should pull a sha1 to make it deterministic, so I think the thing to do is to update this PR to pull the sha1 you want, instead of a named branch. That way you don't end up having to create multiple named branches, you can just add your commits to the main branch and old/new versions of tests will pull from the sha they expect. |
This test was disabled due to redpanda-data#2889 but a lot has changed since then. Re-enable the test with ok_to_fail to see if it continues to fail.
0ab4519
to
c8453a7
Compare
Cover letter
This test was disabled due to #2889 but a lot has changed since then.
Re-enable the test with ok_to_fail to see if it continues to fail.
Release notes