tests: fix version pin for arroyo #5637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker container build failed with the following: ---> Running in c64f400b37eb Cloning into 'arroyo'... fatal: Could not parse object '2631cf1406b0cb5bc05c8a37e8f9f5a40fcf31d4'. The command '/bin/sh -c mkdir /root/external_test_suites && git -C /root/external_test_suites clone --depth=1 https://github.com/getsentry/arroyo.git && cd /root/external_test_suites/arroyo && git reset --hard 2631cf1406b0cb5bc05c8a37e8f9f5a40fcf31d4 && python3 -m pip install --force --no-cache-dir -e /root/external_test_suites/arroyo' returned a non-zero code: 128 task: Failed to run task "rp:run-ducktape-tests": task: Failed to run task "rp:init-ducktape-containers": task: Failed to run task "rp:build-test-docker-image": exit status 128 Looks like we only fetch the latest commit, and the pinned commit is no longer the latest on the default branch. Fortunately, arroyo recently released 1.0.0 that barely differs[1] from the pinned version, so let's just use that. [1] https://github.com/getsentry/arroyo/compare/1.0.0..2631cf1406b0cb5bc05c8a37e8f9f5a40fcf31d4
andrwng
requested review from
nk-87,
VladLazar and
dotnwat
and removed request for
a team
BenPope
approved these changes
Jul 26, 2022
dlex
approved these changes
Jul 26, 2022
|
The test failure was #5613 caught in a different test |
mmedenjak
added
kind/bug
|
That was my bad. Thanks for the fix @andrwng! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker container build failed with the following:
Looks like we only fetch the latest commit, and the pinned commit is no
longer the latest on the default branch. Fortunately, arroyo recently
released 1.0.0 that barely differs[1] from the pinned version, so let's
just use that.
[1] https://github.com/getsentry/arroyo/compare/1.0.0..2631cf1406b0cb5bc05c8a37e8f9f5a40fcf31d4
Release notes