cluster: improved logging during shutdown #5672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For classes that have an asynchronous ::stop method, it is very helpful to log on entry, so that in the event of a shutdown hang bug we have a good chance at telling which shutdown stage had the problem. Logging at INFO is a little verbose, but it is only one time on shutdown & if a user hits a shutdown hang they are unlikely to have debug logs turned on in advance.
jcsp
force-pushed
the
cluster-shutdown-logs
branch
from
ce9e3da
to
e4eeb95
Compare
|
CI failure is ARM builder with full disk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
In shutdown hangs like #5178 (comment) , it can be hard to get a sense of which part of shutdown is in progress when something goes wrong.
This PR adds some additional INFO level logging so that whether in the field or in automated testing, we have a trail of log messages to give us a hint about where the problem lies.
UX changes
Slightly more verbose logging during shutdown.
Release notes