Fixed incorrect assumptions in replace_whole_group test
#5696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed `replace_whole_group` test by waiting for the whole raft group to be up to date before executing configuration change. The test was flaky as sometimes the configuration was changed before propagating any records to one of the nodes (raft correctness is based on majority). This caused the condition validating if some batches are read to fail permanently. Fixes: redpanda-data#342 Signed-off-by: Michal Maslanka <[email protected]>
mmaslankaprv
requested review from
ztlpn,
jcsp,
VadimPlh and
rystsov
as code owners
jcsp
approved these changes
Jul 28, 2022
mmedenjak
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
replace_whole_grouptest by waiting for the whole raft group tobe up to date before executing configuration change.
The test was flaky as sometimes the configuration was changed before
propagating any records to one of the nodes (raft correctness is based
on majority). This caused the condition validating if some batches are
read to fail permanently.
Fixes: #342